Repository navigation
feat: external storage foundation types - #600
Merged
Merged
Conversation
jmaeagle99
force-pushed
the
extstore-foundation
branch
from
October 6, 2026 04:02
74c1f87 to
8381a45
Compare
GregoryTravis
approved these changes
Oct 9, 2026
Co-authored-by: Gregory Michael Travis <greg.m.travis@gmail.com>
…ontext.rb Co-authored-by: Gregory Michael Travis <greg.m.travis@gmail.com>
jmaeagle99
enabled auto-merge (squash)
October 9, 2026 18:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add foundational external storage types to the Ruby SDK, marked
@!visibility privateand unwiredfrom the rest of the SDK.
Temporalio::Converters::StorageDriver— base class users subclass to store and retrieve payloadsin an external system, alongside
StorageDriverClaim, the workflow/activity target info types, andthe store, select and retrieve contexts.
Temporalio::Converters::ExternalStorage— configuration, validated at construction: at least onedriver, unique non-empty driver names, a selector required above one driver, and a non-negative
size threshold.
Temporalio::Internal::ExternalStorageReferences— the on-the-wire reference format.Temporalio::Error::ExternalStorageNotConfiguredError—TMPRL1105.Nothing calls any of this yet. There is no runner, no data converter integration, and no worker or
client wiring.
Why?
Allow parallel development of the external storage system in the Ruby SDK. Keeping the types private
and unwired prevents unintended use.
Notes for Reviewers
StorageDriver#storeand#retrieveare synchronous and may block on I/O, followingPayloadCodec. A driver that wants to work its batch concurrently should fan out with threads,not
Fiber.schedule— the latter raisesNo scheduler is available!when the worker is configuredwith a payload codec thread pool rather than a fiber scheduler, so a fiber-based driver works under
one supported worker configuration and crashes under the other.
StorageDriverClaimdefines==,eql?andhashover its claim data. Java and Python both giveclaims content equality, and identity comparison would make two claims describing the same stored
payload unequal.
Checklist
How was this tested: New unit tests
Any docs updates needed? No. The types are
@!visibility privateand omitted fromCHANGELOG.mduntil external storage is usable.