Repository navigation
Close popup walls before research and stop testing them - #295
Conversation
A cookie consent or marketing modal was treated as the page's main content: Researcher described it and Planner targeted it first. Researcher now asks the oracle whether a detected overlay is a wall, has Navigator close it, and researches only once it is gone. A wall that stays open raises ResearchBlockedError, so Captain takes over planning. Regular modals stay open and are researched as before. Planner no longer plans tests for such popups, and the shared popup rule tells Tester, Navigator, Captain and Rerunner to dismiss or ignore them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace the Navigator call, re-check, ResearchBlockedError and popup rule with one step: when an overlay is detected, ask the oracle whether it is a wall and close it with the existing cancelInUi. The check lives in a WithWalls mixin next to its statement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Explorbot Self-RegressionCommit
Time is the passing attempt (the last attempt if none passed). Change compares it with the median passing time of the last 5 runs; ±20% or more is flagged. Attempt details
Session analysis — basic (native): Session AnalysisCreating an issue, opening its detail view, and the empty-result search state all work in the tested flows. Keyword filtering is not confirmed: its only test had a failed click step, and the empty-title validation test also had failed steps. Coverage
What works
Execution Issues
Session analysis — slow (native): Session AnalysisNew issue creation from the New Issue drawer works. The new issue appears in the list with default status open and priority normal. Coverage
Execution Issues
Session analysis — gated (native): Session AnalysisCreating an issue from the workspace toolbar saves it, and the new issue appears in the issues table with its title. Whether the priority selection was actually applied is not confirmed by a clean run. Coverage
Execution Issues
|
Problem
Explorbot prefers modals as the main content source, so a cookie consent or marketing popup gets researched as the page and becomes a test target.
Change
cancelInUi()closes it and the page is re-captured before research starts. Regular modals stay open and are researched as before. The check and its statement live in a newWithWallsmixin (src/ai/researcher/walls.ts).ignored-pages.mdstops it planning tests for these popups, which also covers small banners that overlay detection ignores.No overlay means no extra AI call.
Known limitations
cancelInUi()only clicks at (0, 0) and presses Escape, so a wall that needs Accept or Reject stays open. Nothing re-checks it, so research continues with the wall in place./plan cookie consentalso has the wall closed before research, so Planner won't see it.Testing
Provider, 1ApibotConfigParser), the same 8 as onmainwithout this change.bun run buildfails locally onchromium-bidiresolution, the same as on a cleanorigin/main.🤖 Generated with Claude Code