Repository navigation
Driver version matrix in CI; virtual clock for timing tests - #21
Merged
Merged
Conversation
…g tests test/compat installs pg, mysql2, mysql, mongodb, mongoose, ioredis and better-sqlite3 majors side by side and checks the exact labels against real servers in a new CI job. It found that mongodb 3.x / Mongoose 5 labelled aggregate() as 'mongo find $cmd', fixed here. Sync timing assertions now run on a virtual clock so machine load cannot fail them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/compat: old and new majors of every instrumented driver on real servers (newdriver-compatCI job, strict: a skipped driver fails).aggregate()was labelledmongo find $cmd.useVirtualClock/withVirtualClock).pg@7 is not in the matrix: it cannot connect on Node 14+ at all, so pg 8.0.3 is the old end.
Not yet covered: Prisma (needs a generated client per version).