Skip to content

Error updating #893

Closed
Closed

Description

@Paymanonline

The applictaion crash on auto update. no matter it's started or not.
It's probably because the guthub download is restricted and it wont use the tunnel for download

Activity

  1. therealaleph commented on May 8, 2026

    @therealaleph
    Owner

    Reviewed via Anthropic Claude.

    @Paymanonline — clarifying which path crashes:

    Note: mhrv-rs in main does not have an auto-apply update path yet (PR #540 by @dazzling-no-more is open but not merged). What main has is:

    1. update_check::check — fetches the latest release JSON from api.github.com
    2. UI shows "Update Available" + a Download button that fetches the asset and saves it to your Downloads folder. You then unzip + replace the binary.

    If "the application crash on auto update" means clicking that Download button:

    • The download attempts via the local proxy when the proxy is running, and direct otherwise.
    • If GitHub is fully blocked on your ISP and the proxy is off, the direct attempt fails — but it should error gracefully, not crash. A crash there is a real bug.

    What I need:

    1. mhrv-rs --version (build you're running)
    2. Was the proxy running when you clicked Download? (UI shows "listening HTTP …" / "SOCKS5 …" lines if yes)
    3. Full panic backtrace from running mhrv-rs-ui from CMD/PowerShell:
      set RUST_BACKTRACE=1
      mhrv-rs-ui.exe
      
      then click Download and paste the panic line + a few stack frames.

    If you mean a custom build with PR #540 applied: please file the bug on the PR thread instead so it gets fixed before merge.

    Closing the abstract "auto update crash" — please reopen with one of the above so we can debug a specific path.

  2. r-safavi commented on May 9, 2026

    @r-safavi

    I have the exact same problem on the UI version on Windows. I have tried with version 1.9.15 (obviously I can't try with the latest version since then there wouldn't be any updates available). I have seen this issue on any version I have downloaded so far. The zip file of the latest version gets downloaded successfully to my Downloads folder, but the UI freezes and I have to force close it. @therealaleph please reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions