Skip to content

Tools: Topology: Add selector to compress playback pipeline #10618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singalsu wants to merge 2 commits into
base: main
Choose a base branch
from
+386 −520
Open

Tools: Topology: Add selector to compress playback pipeline #10618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e5b355
Tools: Topology: Move object formats for compress to include files
singalsu Mar 12, 2026
993f81e
Tools: Topology: Add selector to compress playback pipeline
singalsu Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 107 additions & 0 deletions tools/topology/topology2/include/formats/compr_input_audio_formats.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
# All input formats for e.g. host-copier, decoder,
# and module-copier
num_input_audio_formats 40
CombineArrays.Object.Base.input_audio_format [
{
in_channels [ 1 ]
in_rate [
8000
44100
48000
96000
192000
]
in_bit_depth [ 8 ]
in_valid_bit_depth [ 8 ]
in_sample_type [ $SAMPLE_TYPE_UNSIGNED_INTEGER ]
in_ch_map [ $CHANNEL_MAP_MONO ]
in_ch_cfg [ $CHANNEL_CONFIG_MONO ]
}
{
in_channels [ 1 ]
in_rate [
8000
44100
48000
96000
192000
]
in_bit_depth [ 16 ]
in_valid_bit_depth [ 16 ]
in_ch_map [ $CHANNEL_MAP_MONO ]
in_ch_cfg [ $CHANNEL_CONFIG_MONO ]
}
{
in_channels [ 1 ]
in_rate [
8000
44100
48000
96000
192000
]
in_bit_depth [ 32 ]
in_valid_bit_depth [ 24 ]
in_ch_map [ $CHANNEL_MAP_MONO ]
in_ch_cfg [ $CHANNEL_CONFIG_MONO ]
}
{
in_channels [ 1 ]
in_rate [
8000
44100
48000
96000
192000
]
in_bit_depth [ 32 ]
in_valid_bit_depth [ 32 ]
in_ch_map [ $CHANNEL_MAP_MONO ]
in_ch_cfg [ $CHANNEL_CONFIG_MONO ]
}
{
in_rate [
8000
44100
48000
96000
192000
]
in_bit_depth [ 8 ]
in_valid_bit_depth [ 8 ]
in_sample_type [ $SAMPLE_TYPE_UNSIGNED_INTEGER ]
}
{
in_rate [
8000
44100
48000
96000
192000
]
in_bit_depth [ 16 ]
in_valid_bit_depth [ 16 ]
}
{
in_rate [
8000
44100
48000
96000
192000
]
in_bit_depth [ 32 ]
in_valid_bit_depth [ 24 ]
}
{
in_rate [
8000
44100
48000
96000
192000
]
in_bit_depth [ 32 ]
in_valid_bit_depth [ 32 ]
}
]
29 changes: 29 additions & 0 deletions tools/topology/topology2/include/formats/compr_input_audio_formats_s32_48k.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Input formats for e.g. micsel
num_input_audio_formats 10
CombineArrays.Object.Base.input_audio_format [
{
in_channels [ 1 ]
in_rate [
8000
44100
48000
96000
192000
]
in_bit_depth [ 32 ]
in_valid_bit_depth [ 32 ]
in_ch_map [ $CHANNEL_MAP_MONO ]
in_ch_cfg [ $CHANNEL_CONFIG_MONO ]
}
{
in_rate [
8000
44100
48000
96000
192000
]
in_bit_depth [ 32 ]
in_valid_bit_depth [ 32 ]
}
]
65 changes: 65 additions & 0 deletions tools/topology/topology2/include/formats/compr_input_output_formats_src_s32_to_48k.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
# Input and output audio formats for SRC
num_input_audio_formats 28
CombineArrays.Object.Base.input_audio_format [
{
in_channels [ 1 ]
in_rate [
8000
11025
12000
16000
22050
24000
32000
44100
48000
64000
88200
96000
176400
192000
]
in_bit_depth [ 32 ]
in_valid_bit_depth [ 32 ]
in_ch_map [ $CHANNEL_MAP_MONO ]
in_ch_cfg [ $CHANNEL_CONFIG_MONO ]
}
{
in_rate [
8000
11025
12000
16000
22050
24000
32000
44100
48000
64000
88200
96000
176400
192000
]
in_bit_depth [ 32 ]
in_valid_bit_depth [ 32 ]
}
]

num_output_audio_formats 2
Object.Base.output_audio_format [
{
out_channels 1
out_rate 48000
out_bit_depth 32
out_valid_bit_depth 32
out_ch_map $CHANNEL_MAP_MONO
out_ch_cfg $CHANNEL_CONFIG_MONO
}
{
out_channels 2
out_rate 48000
out_bit_depth 32
out_valid_bit_depth 32
}
]
106 changes: 106 additions & 0 deletions tools/topology/topology2/include/formats/compr_output_audio_formats.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
# Output audio formats for e.g. host-copier and decoder
num_output_audio_formats 40
CombineArrays.Object.Base.output_audio_format [
{
out_channels [ 1 ]
out_rate [
8000
44100
48000
96000
192000
]
out_bit_depth [ 8 ]
out_valid_bit_depth [ 8 ]
out_sample_type [ $SAMPLE_TYPE_UNSIGNED_INTEGER ]
out_ch_map [ $CHANNEL_MAP_MONO ]
out_ch_cfg [ $CHANNEL_CONFIG_MONO ]
}
{
out_channels [ 1 ]
out_rate [
8000
44100
48000
96000
192000
]
out_bit_depth [ 16 ]
out_valid_bit_depth [ 16 ]
out_ch_map [ $CHANNEL_MAP_MONO ]
out_ch_cfg [ $CHANNEL_CONFIG_MONO ]
}
{
out_channels [ 1 ]
out_rate [
8000
44100
48000
96000
192000
]
out_bit_depth [ 32 ]
out_valid_bit_depth [ 24 ]
out_ch_map [ $CHANNEL_MAP_MONO ]
out_ch_cfg [ $CHANNEL_CONFIG_MONO ]
}
{
out_channels [ 1 ]
out_rate [
8000
44100
48000
96000
192000
]
out_bit_depth [ 32 ]
out_valid_bit_depth [ 32 ]
out_ch_map [ $CHANNEL_MAP_MONO ]
out_ch_cfg [ $CHANNEL_CONFIG_MONO ]
}
{
out_rate [
8000
44100
48000
96000
192000
]
out_bit_depth [ 8 ]
out_valid_bit_depth [ 8 ]
out_sample_type [ $SAMPLE_TYPE_UNSIGNED_INTEGER ]
}
{
out_rate [
8000
44100
48000
96000
192000
]
out_bit_depth [ 16 ]
out_valid_bit_depth [ 16 ]
}
{
out_rate [
8000
44100
48000
96000
192000
]
out_bit_depth [ 32 ]
out_valid_bit_depth [ 24 ]
}
{
out_rate [
8000
44100
48000
96000
192000
]
out_bit_depth [ 32 ]
out_valid_bit_depth [ 32 ]
}
]
29 changes: 29 additions & 0 deletions tools/topology/topology2/include/formats/compr_output_audio_formats_s32.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Output audio formats e.g. module-copier
num_output_audio_formats 10
CombineArrays.Object.Base.output_audio_format [
{
out_channels [ 1 ]
out_rate [
8000
44100
48000
96000
192000
]
out_bit_depth [ 32 ]
out_valid_bit_depth [ 32 ]
out_ch_map [ $CHANNEL_MAP_MONO ]
out_ch_cfg [ $CHANNEL_CONFIG_MONO ]
}
{
out_rate [
8000
44100
48000
96000
192000
]
out_bit_depth [ 32 ]
out_valid_bit_depth [ 32 ]
}
]
10 changes: 10 additions & 0 deletions tools/topology/topology2/include/formats/compr_output_audio_formats_s32_48k_stereo.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Micsel single format output
num_output_audio_formats 1
Object.Base.output_audio_format [
{
out_channels 2
out_rate 48000
out_bit_depth 32
out_valid_bit_depth 32
}
]
8 changes: 8 additions & 0 deletions tools/topology/topology2/include/pipelines/cavs/compr-playback.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
<include/components/pipeline.conf>
<include/components/gain.conf>
<include/components/decoder.conf>
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pipeline instantiates a src widget (src."1" {}) but does not include include/components/src.conf in the header includes. This makes the pipeline definition depend on external include order and is inconsistent with other pipeline templates that include their component classes explicitly. Add the missing src.conf include here to keep the pipeline self-contained.

Suggested change
<include/components/decoder.conf>
<include/components/decoder.conf>
<include/components/src.conf>

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator Author

@singalsu singalsu Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

<include/components/micsel.conf>
<include/components/src.conf>

Class.Pipeline."compr-playback" {

Expand Down Expand Up @@ -59,6 +61,8 @@ Class.Pipeline."compr-playback" {

src."1" {}

micsel."1" {}

gain."1" {}

mixin."1" {}
Expand All @@ -81,6 +85,10 @@ Class.Pipeline."compr-playback" {
}
{
source src.$index.1
sink micsel.$index.1
}
{
source micsel.$index.1
sink gain.$index.1
}
{
Expand Down
Loading
Loading