Skip to content

zephyr: idc: Name IDC p4wq threads#10656

Merged
lgirdwood merged 1 commit intothesofproject:mainfrom
jsarha:idc_thread_names
Mar 27, 2026
Merged

zephyr: idc: Name IDC p4wq threads#10656
lgirdwood merged 1 commit intothesofproject:mainfrom
jsarha:idc_thread_names

Conversation

@jsarha
Copy link
Copy Markdown
Contributor

@jsarha jsarha commented Mar 26, 2026

Name IDC p4wq threads. Unfortunately the idc threads only get their names after they are needed for the first time. Until that time they appear as unnamed (a hex number) threads on core 0.

There is also one funny thing. There is static thread reserved for core 0, but that is never activated, and it remains there as a hex number forever.

However, in this simple and risk free convenience fix, I do not dare to touch that. Maybe later.

Name IDC p4wq threads. Unfortunately the idc threads only get their
names after they are needed for the first time. Until that time they
appear as unnamed (a hex number) threads on core 0.

There is also one funny thing. There is static thread reserved for
core 0, but that is never activated, and it remains there as a hex
number forever.

However, in this simple and risk free convenience fix, I do not dare
to touch that. Maybe later.

Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Copilot AI review requested due to automatic review settings March 26, 2026 22:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves runtime observability in the Zephyr IDC implementation by assigning deterministic names to the per-core IDC P4WQ threads, avoiding “unnamed/hex” thread entries in thread listings until first use.

Changes:

  • Add per-core thread name construction in idc_init_thread().
  • Set the P4WQ static thread name via k_thread_name_set() after enabling the static thread.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, less unnamed threads.

@lgirdwood lgirdwood merged commit d7b3131 into thesofproject:main Mar 27, 2026
46 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants