Skip to content

github: workflows: remove zmain build test#10662

Open
lgirdwood wants to merge 1 commit intothesofproject:mainfrom
lgirdwood:workflows
Open

github: workflows: remove zmain build test#10662
lgirdwood wants to merge 1 commit intothesofproject:mainfrom
lgirdwood:workflows

Conversation

@lgirdwood
Copy link
Copy Markdown
Member

This just adds more noise than signal to the CI results.

This just adds more noise than signal to the CI results.

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
@lgirdwood lgirdwood requested a review from dbaluta as a code owner March 27, 2026 20:57
Copilot AI review requested due to automatic review settings March 27, 2026 20:57
@lgirdwood lgirdwood changed the title github: workflows: emove zmain build test github: workflows: remove zmain build test Mar 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the zmain Zephyr build variant from the Zephyr GitHub Actions workflow to reduce CI noise.

Changes:

  • Removed zmain from the zephyr_revision matrix in the Linux build job.
  • Deleted the zmain-specific manifest override generation and west update logic, leaving only the mnfst path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -113,7 +113,6 @@ jobs:
# Search "zephyr_revision" and see below what they expand to.
zephyr_revision: [
mnfst, # special value: don't override sof/west.yml
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the zephyr_revision flow sequence, mnfst still has a trailing comma after removing zmain. YAML flow sequences are typically strict about trailing commas, and this can cause the workflow to fail to parse. Remove the trailing comma (or switch to block-style list) now that there's only one entry.

Suggested change
mnfst, # special value: don't override sof/west.yml
mnfst # special value: don't override sof/west.yml

Copilot uses AI. Check for mistakes.
Comment on lines +169 to 170
echo 'Unknown matrix.zephyr_revision'; exit 1
fi
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the zmain option, there is still a comment later in this job that says "especially in the "zmain" case". Please update/remove that stale reference so the workflow documentation matches the supported zephyr_revision values.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants