Repository navigation
feat(react-ui): add scheme-pinned defaults-light.css and defaults-dar… - #1318
Closed
Jayaram-max wants to merge 1 commit into
Closed
Jayaram-max wants to merge 1 commit into
Jayaram-max wants to merge 1 commit into
Conversation
…k.css defaults.css only applies the dark tokens inside `@media (prefers-color-scheme: dark)`, so an app that forces a scheme with <ThemeProvider mode="dark"> still rendered the stock light tokens on devices whose system scheme is light. Generate two extra stylesheets from the existing token source in generate-css-utils.ts: a complete light and a complete dark token set, each in a plain unlayered :root block with no media query. Expose them as `@openuidev/react-ui/defaults-light.css` and `defaults-dark.css`. - cp-css / css-layer-utils: copy them to dist/styles and keep them unlayered in the layered mirror (shared UNLAYERED_DEFAULTS list) - check-css-artifacts: assert unlayered, :root present, no media query - tests for the unlayered mirror and for token parity / dark overrides - README: document pinning a color scheme; changeset (minor) Closes thesysdev#736 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CrSmpPTChaoEqAMZ7oqn2e
|
@Jayaram2006 is attempting to deploy a commit to the thesys-devs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…k.css
defaults.css only applies the dark tokens inside
@media (prefers-color-scheme: dark), so an app that forces a scheme with still rendered the stock light tokens on devices whose system scheme is light.Generate two extra stylesheets from the existing token source in generate-css-utils.ts: a complete light and a complete dark token set, each in a plain unlayered :root block with no media query. Expose them as
@openuidev/react-ui/defaults-light.cssanddefaults-dark.css.Closes #736
Claude-Session: https://claude.ai/code/session_01CrSmpPTChaoEqAMZ7oqn2e
What
Describe the change and why it is needed.
Changes
Test Plan
Describe how you validated this change.
Checklist