SCAL-314421 Added overrideHistoryState flag to control iframe history behavior#538
Open
shivam-kumar-ts wants to merge 2 commits into
Open
SCAL-314421 Added overrideHistoryState flag to control iframe history behavior#538shivam-kumar-ts wants to merge 2 commits into
shivam-kumar-ts wants to merge 2 commits into
Conversation
commit: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the overrideHistoryState parameter to the BaseViewConfig and Param enum, allowing users to override browser history behavior in embedded contexts by using replaceState instead of pushState. The changes include logic in TsEmbed to pass this parameter to the iframe URL and new unit tests to verify its behavior. Review feedback identified several documentation issues in src/types.ts, including trailing spaces, the use of British English spelling ("honoured"), and syntax or indentation errors within the JSDoc @example block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.