fix

[ruchI9897]

No description provided.

[gemini-code-assist]

Code Review

This pull request implements safety checks for iframe availability in AppEmbed and LiveboardEmbed and updates the scroll event listener removal to use the capture phase. It also adds comprehensive unit tests for these scenarios. The review feedback suggests a performance optimization to check configuration flags before performing layout-triggering calculations, which helps avoid unnecessary browser reflows.

[gemini-code-assist]

The calculateVisibleElementData function is called and its result is computed even when the lazyLoadingForFullHeight and fullHeight conditions are not met. Since calculateVisibleElementData internally calls getBoundingClientRect, which can trigger a browser reflow/layout, it is more efficient to perform the configuration check first and only proceed with the calculation if the event is actually going to be triggered.

        if (this.viewConfig.lazyLoadingForFullHeight && this.viewConfig.fullHeight) {
            if (!this.iFrame?.getBoundingClientRect) {
                return;
            }

            const data = calculateVisibleElementData(this.iFrame);
            this.trigger(HostEvent.VisibleEmbedCoordinates, data);
        }

[gemini-code-assist]

The calculateVisibleElementData function is called and its result is computed even when the lazyLoadingForFullHeight and fullHeight conditions are not met. Since calculateVisibleElementData internally calls getBoundingClientRect, which can trigger a browser reflow/layout, it is more efficient to perform the configuration check first and only proceed with the calculation if the event is actually going to be triggered.

        if (this.viewConfig.lazyLoadingForFullHeight && this.viewConfig.fullHeight) {
            if (!this.iFrame?.getBoundingClientRect) {
                return;
            }

            const data = calculateVisibleElementData(this.iFrame);
            this.trigger(HostEvent.VisibleEmbedCoordinates, data);
        }