Repository navigation
refactor(advisory): drop discoveryLenses and report unjudged batch candidates as gaps - #66
Merged
Merged
Conversation
A batch verifier verdict that is missing or repeated for a candidate now fails that candidate's Verify branch. Before, the candidate became NOT_SUBSTANTIATED with the finder's lens category while the report still read complete, and in code-review that unverified category could promote a merged finding to bug. The report is now incomplete and lists each unjudged candidate in its coverage. The batch schema pins candidateId to the batch's IDs and the verdict count to the batch size, so pi rejects an omitted, extra or mistyped verdict while the verifier can still correct it; only a repeated ID gets past the schema to the runtime check. Merged impacts are deduplicated by line, so a third duplicate no longer repeats an impact the first merge already joined. The verifier prompt and category description name the initial category instead of a discovery lens the record no longer carries.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discoveryLensesfield: no code read it, and the verified category replaced it.incompleteand lists the candidate in its coverage. Before, the candidate becameNOT_SUBSTANTIATEDwith the finder's lens category and the report still saidcomplete. In code-review, that unverified category could promote a merged finding tobug.candidateIds, and exactly one verdict per candidate. pi rejects an omitted, extra or mistyped verdict while the verifier can still fix it. A repeated ID still passes the schema, so a runtime check catches it.A\nB\nA.Test plan
bun run typecheckbun run test(679 pass)