Skip to content

typo?, in param of UtcDateTime::replace_minute / replace_second#779

Merged
jhpratt merged 1 commit intotime-rs:mainfrom
BillGoldenWater:main
May 8, 2026
Merged

typo?, in param of UtcDateTime::replace_minute / replace_second#779
jhpratt merged 1 commit intotime-rs:mainfrom
BillGoldenWater:main

Conversation

@BillGoldenWater
Copy link
Copy Markdown
Contributor

stumbled on this when generating some glue code from source.

but not sure about it since it's like that for 2 years now.

searched issue/pr and found nothing related.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.5%. Comparing base (a5931fe) to head (50ed6bf).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #779   +/-   ##
=====================================
  Coverage   88.5%   88.5%           
=====================================
  Files        100     100           
  Lines      13076   13070    -6     
=====================================
- Hits       11566   11562    -4     
+ Misses      1510    1508    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhpratt
Copy link
Copy Markdown
Member

jhpratt commented May 8, 2026

Ha, I'd be shocked if this isn't me forgetting to rename things after copy-pasting because the functions are so similar. Good catch.

@jhpratt jhpratt merged commit 1a06169 into time-rs:main May 8, 2026
25 checks passed
@jhpratt jhpratt added A-core Area: anything not otherwise covered C-cleanup Category: cleanup of existing code labels May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-core Area: anything not otherwise covered C-cleanup Category: cleanup of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants