Repository navigation
fix(vendor): restore tinywallet 0.29.0 pin reverted by #8655 - #8656
Merged
Merged
Conversation
Update the vendored tinywallet submodule to 0.29.0 and refresh the lockfile so the tinywallet crates resolve to the new version. Auto-committed-on: macbook
Revert the vendored tinywallet submodule and its lockfile entries from 0.29.0 back to 0.28.0, affecting the core crate and its bus, crypto, module, web3, and x402 companions. Auto-committed-on: macbook
Tiny Sweeper review
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#8655's merge brought in two stray commits that undid #8650's tinywallet re-pin:
eddf17b15b"chore(vendor): bump tinywallet submodule" movedvendor/tinywalletfrom522121a(v0.29.0) back to30e92e6(v0.28.0).e3b24c6271"chore(deps): downgrade tinywallet crates to 0.28.0" changed the six tinywallet crates inCargo.lockto 0.28.0.0.28.0 doesn't have
TokenBalanceInfo,NATIVE_WALLET_TOKEN_BALANCESorinto_cli_compatible_json, which #8650 uses. As a result,mainno longer compiles with theweb3feature:This PR puts the gitlink back to v0.29.0 (
522121a, tag v0.29.0) and restoresCargo.lockto the state #8650 merged with (c369124). The two files differ only in those 12 lockfile lines and the gitlink.Regression test
The existing test
modules::registry::tests::tinywallet_registry_matches_the_verified_v0290_release_manifestpins the version andCONTRACT_VERSION == (1, 15). Onmainthe crate doesn't compile, so the test fails. With this change it passes:cargo check --locked --lib --features web3,tinywalletpasses.