Repository navigation
ci(release): release only from main - #126
Conversation
Drop the reviewed-epic release mode: the mode and reviewed_pr inputs, the reviewed dispatch validator, and the call to the epic-only module-reviewed-epic-release workflow. The tag and main release path is unchanged; release.yml is as it was before 77ec9ba. The reviewed-release test script goes with it, and the release workflow tests now assert that a dispatch names only a tag and runs only the module release.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Tiny Sweeper reviewReviewed head: Verdict: Ready for maintainer review · Priority: none Diagnostics and supporting detailsFull summaryPull request purpose (title): ci(release): release only from main. Per the pull-request title and description, this change makes releases come only from main by removing the "reviewed-epic" release mode. The diff restores `.github/workflows/release.yml` to a tag-only additive shape, deletes the dedicated reviewed-epic test file and its CI invocation, and adds a replacement test pinning the simplified workflow shape. The latest-push delta is unavailable. Unreviewed paths
Review snapshot
Completeness: Complete What changed`.github/workflows/release.yml#jobs:` drops the `mode` and `reviewed_pr` dispatch inputs, the `inputs.mode` condition on module-release, and the `validate-reviewed-dispatch` and `module-reviewed-release` jobs, leaving only `resolve` and `module-release` behind the single `tag` input. `.github/workflows/release.yml#name: Release` continues to use the unchanged shared module-release workflow pin. `.github/workflows/ci.yml#jobs:` removes the `python3 scripts/test_reviewed_release_workflow.py` step. `scripts/release_workflow_tests.py#def test_release_uses_the_canonical_module_pipeline(self):` region gains a test asserting `tag` is the only dispatch input, jobs are `[resolve, module-release]`, no reviewed-epic remnants remain, and exactly one shared-workflow call exists. `scripts/test_reviewed_release_workflow.py` is deleted entirely, including its epic-dispatch guards and unrelated Cargo/tinybus manifest guards. Features
Tests
FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
tinysweeper
Bot
added
the
priority: p3
Removes the "reviewed-epic" release mode, so releases are cut only from this repo's main branch.
The mode let a release tag a reviewed PR's merge commit on an epic branch instead of main, through a reusable workflow in tinyhumansai/.github pinned at a commit that's only on that repo's epic branch (sdk-reviewed-epic-release@0cafb7a / module-reviewed-epic-release@6ed83b0). That split version lines and let releases carry code that isn't on main. The decision is that releases come only from the official repo's main.
Changes:
.github/workflows/release.ymlis restored to its state before 77ec9ba (additive).scripts/test_reviewed_release_workflow.pyis deleted, along with its ci.yml line.release_workflow_tests.pygains a test thattagis the only input and the jobs are [resolve, module-release] (10 tests pass). Independent of #125 (0.28.0), which doesn't touch workflows.The ordinary main release path is unchanged: tag push, or dispatch with
tag, through the shared release workflow, which already refuses a tag whose commit isn't an ancestor of origin/main.Validation on the self-hosted Linux runner: the repo's release-workflow tests pass on this commit. Workflow syntax is checked by this PR's GitHub CI.