Fix missing docker runtime dependency (0.1.1)#56
Merged
Conversation
The published 0.1.0 wheel was missing the docker runtime dependency, causing `ModuleNotFoundError: No module named 'docker'` when running the CLI after `pip install regshape`. The docker package was only listed in requirements.txt (used for local dev), not in pyproject.toml's [project].dependencies (used to generate package metadata). - Add `docker>=7.1.0` to runtime dependencies in pyproject.toml. - Move `pytest` into a new [project.optional-dependencies] `dev` extra so it stays out of runtime metadata; install via `pip install regshape[dev]`. - Bump version to 0.1.1 (PyPI does not allow re-uploading 0.1.0).
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes missing docker runtime dependency in the published wheel's metadata, moves pytest to an optional dev extra, and bumps the version to 0.1.1 for PyPI re-publication.
Changes:
- Add
docker>=7.1.0to runtime dependencies. - Add
[project.optional-dependencies]withdev = ["pytest>=9.0.3"]. - Bump version from
0.1.0to0.1.1.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
regshapeafterpip install regshapefrom PyPI fails with:The
dockerpackage is imported byregshape.libs.docker.operationsbut it was not declared as a runtime dependency inpyproject.toml. It was only listed inrequirements.txt, which is used for local development environments and does not influence the metadata of the published wheel.Fix
docker>=7.1.0to[project].dependenciesinpyproject.toml.pytestinto a new[project.optional-dependencies]devextra so it stays out of the runtime metadata (installable viapip install 'regshape[dev]').0.1.1(PyPI does not allow re-uploading0.1.0).Release plan
After this PR is merged, cut a
v0.1.1release and trigger thePublish to PyPIworkflow.