Repository navigation
Chores: Updating repos and Lean version support - #80
Merged
Merged
Conversation
Lean reworked the String type around UTF-8 slices (landing by v4.35) and removed the whole-String spellings String.trim, trimLeft, trimRight, dropRightWhile, takeRightWhile, and dropRight, which the TacticParser source uses. Add existence-gated shims in Compat.lean that reintroduce each spelling only when the corresponding String.* constant is absent from the environment, so toolchains that still provide the core definition use it unchanged while newer ones get the shim. Shims use only primitives stable across the supported range (String.toList, String.push, Char.isWhitespace, List ops). Also widen the version regex in tactic_parser.py to accept release-candidate suffixes (e.g. 4.36.0-rc2), and import Compat into Base64.lean so the shims are in scope there. Verified: full build on 4.27.0, 4.30.0, 4.35.0, and 4.36.0-rc2; end-to-end data extraction clean on batteries (4.36.0-rc2) and miniF2F (4.27.0). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- batteries: bump to v4.36.0-rc2 - cslib: bump to v4.36.0-rc2 - Mathlib (repl-mathlib-tests): repin mathlib require and lean-toolchain to v4.36.0-rc2 and regenerate lake-manifest.json - miniF2F-lean4: point submodule at amit9oct fork on Lean 4.27.0 - clever: bump to latest version Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Lean 4.36.0 support to tactic parser with backward compatibility
Lean reworked the String type around UTF-8 slices (landing by v4.35) and
removed the whole-String spellings String.trim, trimLeft, trimRight,
dropRightWhile, takeRightWhile, and dropRight, which the TacticParser source
uses. Add existence-gated shims in Compat.lean that reintroduce each spelling
only when the corresponding String.* constant is absent from the environment,
so toolchains that still provide the core definition use it unchanged while
newer ones get the shim. Shims use only primitives stable across the supported
range (String.toList, String.push, Char.isWhitespace, List ops).
Also widen the version regex in tactic_parser.py to accept release-candidate
suffixes (e.g. 4.36.0-rc2), and import Compat into Base64.lean so the shims are
in scope there.
Verified: full build on 4.27.0, 4.30.0, 4.35.0, and 4.36.0-rc2; end-to-end data
extraction clean on batteries (4.36.0-rc2) and miniF2F (4.27.0).