[TRUNK-17695] Document impacted targets visualization in merge graph UI#458
[TRUNK-17695] Document impacted targets visualization in merge graph UI#458samgutentag wants to merge 1 commit intomainfrom
Conversation
|
Merging to
|
|
Claude finished @samgutentag's task in 2m 22s —— View job Review complete
The new documentation is clearly written and well-structured overall. A few issues to address before merging: Blocking concerns:
Non-blocking suggestions:
|
|
|
||
| This is useful for debugging unexpected queue ordering or understanding why specific PRs are batched together. | ||
|
|
||
| #### Impacted targets on the PR detail page |
There was a problem hiding this comment.
Structural placement concern: This subsection discusses the PR detail page, but it's nested under ### Graph view. The PR detail page is a separate UI section, documented later under ## Pull request details. Consider either:
- Moving this subsection under
## Pull request details, or - Adding a brief note that users can access the targets modal from the graph by clicking through to a PR's detail page, to justify the placement here.
As written, readers browsing the "Graph view" section may find the PR detail page content unexpected here.
|
|
||
| * **IMPACTS\_ALL**: The PR impacts all targets, so no parallel optimization is possible. | ||
| * **Specific targets**: A list of each target the PR impacts. | ||
| * **No targets uploaded**: No targets were provided, so the PR is treated as IMPACTS\_ALL for safety. |
There was a problem hiding this comment.
Formatting inconsistency: IMPACTS_ALL is bolded (**IMPACTS\_ALL**) in the bullet label on line 63, but appears unformatted inline here. For consistency, apply the same formatting:
| * **No targets uploaded**: No targets were provided, so the PR is treated as IMPACTS\_ALL for safety. | |
| * **No targets uploaded**: No targets were provided, so the PR is treated as **IMPACTS\_ALL** for safety. |
Alternatively, consider using backtick code formatting (`IMPACTS_ALL`) throughout, since this appears to be an enum/constant value.
| When running in [Parallel mode](../optimizations/parallel-queues/), the graph view shows impacted targets information to help you understand why PRs are grouped or ordered the way they are. | ||
|
|
||
| * **Per-PR tooltips**: Hover over a PR node to see which targets that PR impacts. | ||
| * **Overlapping targets on edges**: Use the **Show impacted targets** toggle to display which targets overlap between connected PRs. Overlapping targets explain why PRs are in the same testing sequence — PRs with shared targets must test together. |
There was a problem hiding this comment.
Open question (from PR description): The toggle is referred to as "Show impacted targets" here. Please confirm this matches the exact label in the UI before merging — the PR body flags this as an open question.
|
|
||
| #### Impacted targets on the PR detail page | ||
|
|
||
| On any PR's detail page, click **View impacted targets** to see the full list of uploaded targets. The modal shows one of three states: |
There was a problem hiding this comment.
Open question (from PR description): Does the View impacted targets modal appear for PRs in Single mode as well, or only in Parallel mode? If it's Parallel-mode-only, add a qualifier here similar to the note in the section above:
When running in Parallel mode, on any PR's detail page…
Add sections for impacted targets tooltips, overlapping targets on graph edges, and the impacted targets modal on the PR detail page. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8304fc9 to
5d2a43a
Compare
Summary
• Added "Impacted targets in the graph" subsection to the Graph view on the Monitor queue status page — covers per-PR tooltips and overlapping targets toggle
• Added "Impacted targets on the PR detail page" subsection — covers the View impacted targets modal with IMPACTS_ALL, specific targets, and no targets states
Note: The metrics filtering by impacted targets is already documented in
merge-queue/administration/metrics.md, so no update needed there.Context links
Files changed
merge-queue/using-the-queue/monitor-queue-status.md— new subsections under Graph viewOpen questions
Test plan
🤖 Generated with Claude Code