Skip to content

switch to isDoneRendering() for the worker rendering loop #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seveibar wants to merge 1 commit into from
+1 −1
Closed

switch to isDoneRendering() for the worker rendering loop #3207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/shared/generate-circuit-json.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@

const loggedAsyncEffectNames = new Set<string>()

while (runner._hasIncompleteAsyncEffects()) {
while (runner.isDoneRendering()) {

Check failure on line 138 in lib/shared/generate-circuit-json.tsx

View workflow job for this annotation

GitHub Actions / test (3)

TypeError: runner.isDoneRendering is not a function. (In 'runner.isDoneRendering()' 


      at generateCircuitJson (/home/runner/work/cli/cli/lib/shared/generate-circuit-json.tsx:138:17)
      at async <anonymous> (/home/runner/work/cli/cli/tests/shared/static-file-loader-map.test.ts:64:33)
for (const asyncEffect of runner.getRunningAsyncEffects()) {
const asyncEffectName = asyncEffect.effectName
if (!asyncEffectName || loggedAsyncEffectNames.has(asyncEffectName)) {
Expand Down
Loading