Remove deprecated convert CLI command in favour of export#3216
Draft
rushabhcodes wants to merge 1 commit into
Draft
Remove deprecated convert CLI command in favour of export#3216rushabhcodes wants to merge 1 commit into
convert CLI command in favour of export#3216rushabhcodes wants to merge 1 commit into
Conversation
convert CLI command in favour of export
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the deprecated
tsci convertcommand from the CLI in favour oftsci exportand cleans up the direct dependencies that were only used by that command.Changes
registerConvertfrom the CLI entrypointcli/convert/register.tscommand implementationconvertCLI testcircuit-json-to-tscircuitfrom direct dependencieskicad-component-converterfrom direct dependenciesconvertWhy
The
convertcommand is deprecated and no longer needed in the CLI surface. Removing it also lets this package drop the direct dependencies that only existed to support that command.Validation
bunx tsc --noEmitbun run buildbun ./cli/main.ts --helpno longer listsconvertcircuit-json-to-tscircuitis no longer referenced anywhere in this repoNotes
kicad-component-convertermay still appear inbun.lockas a transitive dependency throughtscircuit, even though it is no longer a direct dependency of this package