fix: skip net-label-only MSP routes#324
Open
Kidkrow12 wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Hi! This PR takes the "or remove trace" path from #79 by preventing net-label-only connections from generating MSP routed traces, while preserving net-label connectivity for label placement. All checks are green. Could you confirm whether this matches the intended resolution for #79, or if you prefer the "fix extra net label" direction instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
directConnectionsnetConnectionsso global label connectivity cannot mutate the direct route mapBounty
/claim #79
Test plan
npx.cmd bun test tests\solvers\MspConnectionPairSolver\msp-connection-pair-solver-repro79.test.ts tests\solvers\MspConnectionPairSolver\MspConnectionPairSolver_repro1.test.tsnpx.cmd tsc --noEmitnpx.cmd biome format lib\solvers\MspConnectionPairSolver\MspConnectionPairSolver.ts lib\solvers\MspConnectionPairSolver\getConnectivityMapFromInputProblem.ts tests\solvers\MspConnectionPairSolver\msp-connection-pair-solver-repro79.test.ts tests\solvers\MspConnectionPairSolver\MspConnectionPairSolver_repro1.test.tsNotes
npm.cmd run buildgenerateddist/index.d.ts, then the ESM build hit the local Windows/esbuild path/access error:Cannot read directory "../../../../..": Access is denied.