Skip to content

fix: skip net-label-only MSP routes#324

Open
Kidkrow12 wants to merge 2 commits into
tscircuit:mainfrom
Kidkrow12:codex/fix-net-label-only-msp-routes
Open

fix: skip net-label-only MSP routes#324
Kidkrow12 wants to merge 2 commits into
tscircuit:mainfrom
Kidkrow12:codex/fix-net-label-only-msp-routes

Conversation

@Kidkrow12
Copy link
Copy Markdown

Summary

  • keep direct-route MSP generation limited to directConnections
  • clone the direct connectivity map before adding netConnections so global label connectivity cannot mutate the direct route map
  • preserve global connectivity for later net-label placement while preventing net-label-only pins from becoming wire traces
  • add regression coverage for pure net-label-only nets and mixed direct + net-label nets

Bounty

/claim #79

Test plan

  • npx.cmd bun test tests\solvers\MspConnectionPairSolver\msp-connection-pair-solver-repro79.test.ts tests\solvers\MspConnectionPairSolver\MspConnectionPairSolver_repro1.test.ts
  • npx.cmd tsc --noEmit
  • npx.cmd biome format lib\solvers\MspConnectionPairSolver\MspConnectionPairSolver.ts lib\solvers\MspConnectionPairSolver\getConnectivityMapFromInputProblem.ts tests\solvers\MspConnectionPairSolver\msp-connection-pair-solver-repro79.test.ts tests\solvers\MspConnectionPairSolver\MspConnectionPairSolver_repro1.test.ts

Notes

  • npm.cmd run build generated dist/index.d.ts, then the ESM build hit the local Windows/esbuild path/access error: Cannot read directory "../../../../..": Access is denied.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
schematic-trace-solver Ready Ready Preview, Comment May 12, 2026 9:23pm

Request Review

@Kidkrow12
Copy link
Copy Markdown
Author

Hi! This PR takes the "or remove trace" path from #79 by preventing net-label-only connections from generating MSP routed traces, while preserving net-label connectivity for label placement.

All checks are green. Could you confirm whether this matches the intended resolution for #79, or if you prefer the "fix extra net label" direction instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant