Fix overlap offset selection to minimize crossings#325
Open
theRadicalSoftware wants to merge 1 commit into
Open
Fix overlap offset selection to minimize crossings#325theRadicalSoftware wants to merge 1 commit into
theRadicalSoftware wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Hi @seveibar, checking in on this when you have a chance. All checks are passing, Algora picked up the Happy to adjust the offset heuristic or narrow the snapshot changes if you prefer a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83
/claim #83
Summary
Updates
TraceOverlapIssueSolverso overlapping parallel traces evaluate both offsetdirections and choose the direction with fewer cross-net trace segment intersections.
This prevents the solver from picking a backward/suboptimal offset purely because of net
iteration order.
Also adds a focused regression test and updates affected SVG snapshots for the improved
routing output.
Tests
bun test- 58 pass, 4 skip, 0 failbunx tsc --noEmitbun run format:check