Only reiterate failure to create metadata for each node if log level is debug or finer#131
Merged
TimHeldmann merged 4 commits intotudasc:develfrom Apr 17, 2026
Merged
Conversation
Member
Author
|
In this PR I currently query the loglevel directly via spdlog's interface. |
TimHeldmann
force-pushed
the
feat/reduceWarningSpam
branch
from
d39c40a to
1401baf
Compare
pearzt
approved these changes
Mar 11, 2026
jplehr
reviewed
Mar 11, 2026
jplehr
approved these changes
Mar 13, 2026
Member
jplehr
left a comment
jplehr
left a comment
There was a problem hiding this comment.
How about changing commit title to something like this:
[Graph] Emit create-MD error per node/edge in debug-level
Can you give it one more git-clang-format just to be sure? Thanks!
…is debug or finer
…ning if it is, but could not be created
TimHeldmann
force-pushed
the
feat/reduceWarningSpam
branch
from
d3db4d6 to
d8fa2bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When looking in the logs of our container build, I found that
After logging that we can not create "SomeMetadata", we additionally log that we can not create "SomeMetadata" for each node it was attached to. While I see how this could be helpful for debugging failure to create Metadata on certain nodes, I propose to limit the logging per node to debug or trace logging granularity
We did not log this failure for edge-based metadata, only for node and global metadata. I unified this behavior.