restore selectAlternateInterface in camera worker#13
Merged
Conversation
🦋 Changeset detectedLatest commit: cdd9ac6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c27527a to
cdd9ac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11.
Summary
selectAlternateInterfaceafterclaimInterfacein the camera worker. The call was dropped in major refactor #4 (Oct 2025 refactor), which madeCamera.setMode({ depth: ... })crash the Chromium USB utility process on Linux withusb_device_handle_usbfs.cc Invalid argument (22). Linux usbfs needs an explicitSET_INTERFACEioctl to reserve iso bandwidth before iso URB submission; macOS IOUSBLib was permissive enough to hide the regression.iface.alternate.alternateSetting(matches pre-refactor behavior; defensive against SKU/firmware variants vs. hard-coding0).prepareCamDeviceout ofworker.tsso the claim → select-alt sequence is unit-testable in isolation (worker.ts has top-levelself.addEventListenerside effects that make direct import awkward). New tests pin the call ordering and descriptor-driven alt forwarding so this can't silently regress again.Test plan
pnpm --filter @webnect/driver buildclean (tsc)pnpm --filter @webnect/driver test— 11/11 passing, 5 new underdriver/test/prepare-cam-device.test.tsCamera.setMode({ depth: ... })streams depth without crashing the USB utility process;chromium-browser.logclean ofInvalid argument (22)🤖 Generated with Claude Code