[pull] master from php:master#818
Merged
pull[bot] merged 7 commits intoturkdevops:masterfrom Mar 27, 2026
Merged
Conversation
- add const qualifiers - reduce variable scope - use bool type instead of int type
This test takes 140s on my machine with ASAN, and thus cause a bunch of timeouts in nightly. The issue reproduces with 16M, reducing execution time to 20s. Also mark the tests as slow.
* PHP-8.4: Reduce memory limit for gh19983.phpt
* PHP-8.5: Reduce memory limit for gh19983.phpt
No need to check for UNDEF, assume the index is undefined. This eliminates the offset calculation, lookup and type check. Though of course dwarfed by the conversion to a proper hash table.
* PHP-8.5: Fix ZEND_API mismatch on zend_ce_closure forward decl for Windows+Clang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )