[pull] master from ruby:master#884
Merged
pull[bot] merged 12 commits intoturkdevops:masterfrom Mar 25, 2026
Merged
Conversation
- This new suite needs to be added to a group in order to be picked up. I saw the warning on CI ./spec/bundler/errors_spec.rb is not assigned to any Windows runner group. see spec/support/windows_tag_group.rb for details. ruby/rubygems@ed87214b37
They can take a block and so the keyword location is not always the entirety of the node. You can get it by constructing a location that is just the first 5 characters but why not have it be provided by prism? ruby/prism@878d79eb8c
#16541) Change vm_search_method_fastpath, vm_search_method, vm_method_cfunc_is, opt_equality, vm_opt_neq, vm_opt_nil_p, vm_opt_not, and vm_objtostring to take a CFP instead of an iseq. The iseq is now read lazily from reg_cfp->iseq only when the slowpath is actually needed. This is a preparatory refactoring for lightweight JIT frames where the iseq may not always be written eagerly to the CFP. ZJIT's rb_zjit_vm_search_method and rb_vm_method_cfunc_is, which are called with a compile-time iseq rather than a live CFP, now call the slowpath directly.
The caller in gen_send_iseq_direct was eagerly writing Qnil to all non-parameter local slots of the callee's frame before every JIT-to-JIT call. This is unnecessary because compile_jit_entry_state already initializes non-parameter locals to Const(Qnil) in the JIT entry block, and these values are propagated to the target block via branch edges. Before any non-leaf call (including eval/binding), gen_spill_locals writes these nil values from the FrameState to the stack, ensuring that eval can correctly read uninitialized locals as nil. The nil-fill in function_stub_hit's prepare_for_exit is kept because that path handles compilation failures where JIT code never runs.
Previously we would side-exit if the index was negative. Instead, adjust the index to be in-bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )