Use CLDR names in emoji list#8422
Open
MDLC01 wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
I opened progval/unicode_names2#57 |
Collaborator
Author
|
|
laurmaedje
added
waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8340.
Honestly, the status quo is quite bad for the emoji list; even the imperfect solution proposed in this PR is better. Emoji haven't been given much love in Codex either, but I would like to get to it at some point, starting with flags.
Here is how the title of a symbol flyout is determined now:
unicode_names2, use that name.I would like to get rid of 3., but sadly
unicode_names2has not been updated to Unicode 17.0. I will make a PR there soon, but I am not convinced a new version will be released in time (the last commit was 9 months ago, and there are open PRs from almost a year ago). This is only an issue for a couple symbols, so it's probably fine.Regarding 1., as explained in #8340, ICU4X does not expose CLDR short names for now. I opted for the easiest solution: use the emoji-zwj-sequences.txt file (added to
typst-dev-assetsin typst/typst-dev-assets#30), which contains most names we care about. This not the most satisfying solution, but it is barely distinguishable from an ideal solution to the end user, which is what matters in the end.Marking as a draft until I can figure out whether it's possible to getDone.unicode_names2to update to Unicode 17.0.