[Rolling] Replace removed ament_target_dependencies in crcopen_hardware CMake#9
Open
abdullah-ukaea wants to merge 2 commits intomainfrom
Open
[Rolling] Replace removed ament_target_dependencies in crcopen_hardware CMake#9abdullah-ukaea wants to merge 2 commits intomainfrom
abdullah-ukaea wants to merge 2 commits intomainfrom
Conversation
…with modern target-based include/link/export rules to restore ROS 2 Rolling colcon build compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates crcopen_hardware/CMakeLists.txt to use target-based include/link/export settings instead of ament_target_dependencies so the package builds again on ROS 2 Rolling after the API removal.
Terminal Output before
Terminal Output After
**
**