docs: spinner design spec + doc refresh#64
Merged
Merged
Conversation
CLAUDE.md: - New "Session Spinners" section covering the launch + shutdown overlays, the 8s silent-session fallback, and the OnClosing yield pattern. - New "Visual Studio: Hot Reload disabled" callout under Build & Run explaining the launchSettings.json + MetadataUpdaterSupport workaround for the .NET 10.0.8 + VS 18 ExecutionEngineException crash. - Architecture > Key layers: PseudoTerminal entry now mentions the IPseudoTerminal seam so contributors see how RunInstance/SessionRunner get tested without spawning a real ConPTY. - Testing section: documents IPseudoTerminal injection, SearchService's per-test temp-SQLite + ClearAllPools pattern, and the timestamp-seeding rule (don't rely on Task.Delay for ordering). README.md: - Adds bullets for the visible features that were missing: sidebar groups, recently-closed (Ctrl+Shift+T), per-session run commands (F5), Windows Terminal profile import, and the launching/shutdown spinners. - Keyboard shortcuts table now lists Ctrl+Shift+T, Ctrl+Alt+T, Ctrl+Shift+Tab, F5, and Shift+F5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two commits:
4e24ea1— Adds the spinner design spec + implementation plan. These two markdown files live alongside the existing superpowers/specs and superpowers/plans for traceability. The matching implementation already shipped via PR feat(bundle): low-hanging fruit + tests, refactor, docs #63; this PR just records the design that drove it.`abfb23a` — Refreshes CLAUDE.md and README for the post-bundle state.
Why this is a separate PR
These are the only commits that were unique to PR #62 (feat/session-spinners). #62 was closed unmerged after PR #63 landed the spinner code itself; this PR is a clean follow-up so the design docs and the doc refresh aren't lost.
Test plan
🤖 Generated with Claude Code