Converted C++ aruco node/package to python#95
Open
MidnightRaider06 wants to merge 7 commits intoumdloop:mainfrom
Open
Converted C++ aruco node/package to python#95MidnightRaider06 wants to merge 7 commits intoumdloop:mainfrom
MidnightRaider06 wants to merge 7 commits intoumdloop:mainfrom
Conversation
mdurrani808
reviewed
Apr 7, 2026
Collaborator
There was a problem hiding this comment.
Standardize on just publishing a vision_msgs/Detection2DArray
Collaborator
There was a problem hiding this comment.
Or another message, use your judgement
| self.destroy_subscription(self.camera_info_sub_) | ||
| self.camera_info_sub_ = None | ||
|
|
||
| def image_callback(self, msg): |
Collaborator
There was a problem hiding this comment.
remove this callback, we can have a generic node that subscribes to a detection 2d array and the source image and publish it, reason is we don't want to send this traffic across the netwrok if we don't have to
…thena-code into refactor/aruco_python
Contributor
Author
|
Using a newer opencv-contrib-python that's still compatible with numpy<2.0. Changed the published message to just a Detection2D but lmk if you think Detection2DArray would be better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.