feat: make --no-sandbox configurable in BrowserConfig (#1701)#1875
Open
hafezparast wants to merge 1 commit intounclecode:developfrom
Open
feat: make --no-sandbox configurable in BrowserConfig (#1701)#1875hafezparast wants to merge 1 commit intounclecode:developfrom
hafezparast wants to merge 1 commit intounclecode:developfrom
Conversation
Add `no_sandbox` param (default True) to BrowserConfig so enterprise deployments can enable Chromium's sandbox protection. Previously --no-sandbox was always hardcoded in both ManagedBrowser.build_browser_flags() and BrowserManager._build_browser_args(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no_sandboxparam toBrowserConfig(defaultTrue— fully backward compatible)no_sandbox=False, the--no-sandboxChromium flag is omitted, enabling browser sandbox protectionManagedBrowser.build_browser_flags()andBrowserManager._build_browser_args()Closes discussion #1701
Usage
Test plan
BrowserConfig()still includes--no-sandbox(backward compat)no_sandbox=Falseexcludes--no-sandboxfrom both build_browser_flags and _build_browser_argsto_dict()/load()roundtrip preserves the valueclone()preserves and can override the valuetests/general/— 48 passed, 5 skippedtests/docker/test_pool_release.py— 10/10 passed🤖 Generated with Claude Code