Skip to content

add cleanup if start() of creating a new crawler fails #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nameearly wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −7
Open

add cleanup if start() of creating a new crawler fails #1884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions deploy/docker/crawler_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ async def get_crawler(cfg: BrowserConfig) -> AsyncWebCrawler:
except:
pass

return HOT_POOL[sig]
return crawler

logger.info(f"❄️ Using cold pool browser (sig={sig[:8]})")
return crawler
Expand All @@ -111,12 +111,17 @@ async def get_crawler(cfg: BrowserConfig) -> AsyncWebCrawler:
# Create new in cold pool
logger.info(f"🆕 Creating new browser in cold pool (sig={sig[:8]}, mem={mem_pct:.1f}%)")
crawler = AsyncWebCrawler(config=cfg, thread_safe=False)
await crawler.start()
crawler.active_requests = 1
COLD_POOL[sig] = crawler
LAST_USED[sig] = time.time()
USAGE_COUNT[sig] = 1
return crawler
try:
await crawler.start()
crawler.active_requests = 1
COLD_POOL[sig] = crawler
LAST_USED[sig] = time.time()
USAGE_COUNT[sig] = 1
return crawler
except Exception:
# Clean up crawler on start failure to prevent resource leak
await crawler.close()
raise

async def release_crawler(crawler: AsyncWebCrawler):
"""Decrement active request count for a pooled crawler.
Expand Down