Skip to content

fix(Boot): pool disappears for missing/wrong disk.#2609

Draft
SimonFair wants to merge 1 commit intounraid:masterfrom
SimonFair:fix(Boot)-fix-error-states-
Draft

fix(Boot): pool disappears for missing/wrong disk.#2609
SimonFair wants to merge 1 commit intounraid:masterfrom
SimonFair:fix(Boot)-fix-error-states-

Conversation

@SimonFair
Copy link
Copy Markdown
Contributor

@SimonFair SimonFair commented Apr 3, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved accuracy of boot disk pool detection and listing
    • Fixed boot partition display when system data is incomplete
    • Enhanced fallback handling for boot pool identification

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6887d062-8da8-4b26-ad55-b859c8490378

📥 Commits

Reviewing files that changed from the base of the PR and between 16bff4a and 9b6b760.

📒 Files selected for processing (1)
  • emhttp/plugins/dynamix/nchan/device_list

Walkthrough

The change extends pool detection logic to include boot disk pools in the $allPools set and refines boot partition rendering by normalizing $poolBootDisk to an empty array instead of skipping, with improved fallback handling for pool name resolution and a new guard condition to prevent unnecessary rendering.

Changes

Cohort / File(s) Summary
Boot Disk Pool Detection
emhttp/plugins/dynamix/nchan/device_list
Extended $allPools computation to iterate over boot disks and add their pool names; changed $poolBootDisk handling to normalize empty results to empty array; added fallback to $pool when boot pool name resolution is empty; implemented guard condition to skip rendering when boot disk data, cache disk data, first member, and pool key are all absent.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Boot disks now dance in pooling arrays,
With fallback logic brightening the ways,
Guard conditions stand like sentries tall,
Ensuring no empty pools render at all! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the fix addressing boot pool visibility issues when disks are missing or misconfigured, directly matching the changeset's core objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.04.03.0817
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2609/webgui-pr-2609.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix/nchan/device_list

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2609, or run:

plugin remove webgui-pr-2609

🤖 This comment is automatically generated and will be updated with each new push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant