Add support for underscores to be in callback assert custom class#233
Merged
miguelfbrito merged 1 commit intomasterfrom Mar 31, 2026
Merged
Conversation
53230c0 to
32b774e
Compare
32b774e to
2a4cdcf
Compare
There was a problem hiding this comment.
Pull request overview
Adds support for underscores in CallbackAssert custom class names by relaxing the validation regex, and introduces a regression test intended to verify the new accepted format.
Changes:
- Allow
_in callback assertcustomClassname validation. - Add/adjust tests for underscore-containing custom class names.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/asserts/callback-assert.js |
Updates the custom class name validation regex to accept underscores. |
test/asserts/callback-assert.test.js |
Adds tests intended to validate underscore support (currently introduces failing/inconsistent assertions). |
Comments suppressed due to low confidence (1)
test/asserts/callback-assert.test.js:111
- This new "should not throw" test duplicates the existing one above and doesn't assert anything (so it would pass even if an exception is thrown by a different async context later). Consider removing it, or converting it to the same
assert.doesNotThrow(() => ...)pattern and/or using it to specifically validate that an underscore-containingcustomClasspasses when the callback returnstrue.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2a4cdcf to
24a34ae
Compare
miguelfbrito
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for underscores to be considered valid in the callback assert custom class name.