test(unikernels): add unit tests for Rumprun#655
Open
r0hansaxena wants to merge 2 commits into
Open
Conversation
Signed-off-by: r0hansaxena <rohansxn8772@gmail.com>
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cmainas
reviewed
Jun 2, 2026
Contributor
cmainas
left a comment
cmainas
left a comment
There was a problem hiding this comment.
Hello @r0hansaxena ,
thank you for the PR. I have added one comment and please do not use different unit tests for the same function. The tests TestRumprunCommandString_* should be merged under one unit test with sub tests using tables.
Signed-off-by: r0hansaxena <rohansxn8772@gmail.com>
Author
|
Could you have a look again? @cmainas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for the Rumprun unikernel backend, covering SupportsBlock, SupportsFS, MonitorNetCli, MonitorBlockCli, MonitorCli, CommandString and Init. Tests verify the hvt/spt net flags (
--net:tap,--net-mac:tap), block passthrough using the fixedrootfsID, the JSON-like command string construction for cmdline, env vars, net and blk sections, and that Init correctly wires up network interface fields and block device paths.Related issues
How was this tested?
All unit tests pass locally. Full package tests pass. Linter passes (make lint, 0 issues).
LLM usage
LLM assisted with locating coverage gaps only. All code was written manually and tested locally.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).