fix(unikontainers): preserve slice order when removing element#678
Merged
Merged
Conversation
✅ Deploy Preview for urunc canceled.
|
Contributor
Author
|
Hey @cmainas , Could you please have a look at this PR whenever you have time? Thanks! |
Contributor
|
Hello @mdryaan , the PR looks good. Can you rebase over main? |
Signed-off-by: mdryaan <alikhurshid842001@gmail.com>
mdryaan
force-pushed
the
fix/remove-preserves-order
branch
from
05846d1 to
5a99b19
Compare
Contributor
Author
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 2, 2026
PR: #678 Signed-off-by: mdryaan <alikhurshid842001@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
urunc-bot Bot
pushed a commit
that referenced
this pull request
Jun 2, 2026
PR: #678 Signed-off-by: mdryaan <alikhurshid842001@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
remove()inpkg/unikontainers/utils.goremoved an element by swapping it with the last element before truncating. This destroyed the ordering of all remaining elements. Both call sites are affected:handleQueueProxy(removesSERVING_READINESS_PROBEfromspec.Process.Env) and the vAccel env cleanup inunikontainers.go(removesVACCEL_RPC_ADDRESS). Replace the swap-and-truncate withappend(s[:i], s[i+1:]...)to preserve order.Related issues
How was this tested?
Added
TestRemovePreservesOrdertopkg/unikontainers/utils_test.go. The testcalls
remove([]string{"a", "b", "c", "d"}, 0)and asserts the result is["b", "c", "d"].Before fix:
After fix:
Run with:
go test ./pkg/unikontainers/ -v -run TestRemovePreservesOrder
golangci-lint runpasses with 0 issues.makebuilds successfully.LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).