Repository navigation
chore: update Swoole to v6.2.5 and check upload marker handling - #22
Merged
Merged
Conversation
v6.2.4 unlinks the path named by a client-supplied Swoole-Upload-File part header; v6.2.5 ignores it (swoole/swoole-src#6309). tests-swoole.php runs against every built image and fails if the named file is deleted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🟢 Tier S · Ready to merge
Updates Swoole to v6.2.5 for PHP 8.3, 8.4, and 8.5. Adds a CI check that sends a multipart request with a client-supplied
📂 Walkthrough · 5
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.1.5 ships Swoole v6.2.4, which treats a client-supplied
Swoole-Upload-Filemultipart part header as an upload and unlinks the path it names when the request ends. v6.2.5 ignores the header (swoole/swoole-src#6309).tests-swoole.phpruns in the structure job against every built image: it posts the header naming an existing file and fails if the file is gone. Same check as fix: hold swoole at 6.2.3 and test upload marker handling appwrite/docker-base#135, without the handler clearingtmpfiles, so it tests Swoole alone.Seen red and green locally on PHP 8.5:
appwrite/utopia-base:php-8.5-2.1.5(Swoole 6.2.4):status 200, target deleted, exit 1status 200, target kept, exit 0After merge: release 2.1.6.
🤖 Generated with Claude Code