Skip to content

chore: update Swoole to v6.2.5 and check upload marker handling - #22

Merged
loks0n merged 1 commit into
mainfrom
chore/swoole-6.2.5
Nov 9, 2026
Merged

loks0n merged 1 commit into
mainfrom
chore/swoole-6.2.5

Conversation

@loks0n

@loks0n loks0n commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

2.1.5 ships Swoole v6.2.4, which treats a client-supplied Swoole-Upload-File multipart part header as an upload and unlinks the path it names when the request ends. v6.2.5 ignores the header (swoole/swoole-src#6309).

Seen red and green locally on PHP 8.5:

  • appwrite/utopia-base:php-8.5-2.1.5 (Swoole 6.2.4): status 200, target deleted, exit 1
  • this branch (Swoole 6.2.5): status 200, target kept, exit 0

After merge: release 2.1.6.

🤖 Generated with Claude Code

v6.2.4 unlinks the path named by a client-supplied Swoole-Upload-File part
header; v6.2.5 ignores it (swoole/swoole-src#6309). tests-swoole.php runs
against every built image and fails if the named file is deleted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@loks0n loks0n self-assigned this Nov 9, 2026
@appwrite

appwrite Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The version updates and the CI regression check are consistent with the described fix, with no actionable issues identified.

Updates Swoole to v6.2.5 for PHP 8.3, 8.4, and 8.5. Adds a CI check that sends a multipart request with a client-supplied Swoole-Upload-File part header and verifies the named file remains present.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 5
File Change
.github/workflows/ci.yml Runs the Swoole upload-marker regression check against each built image in the structure-test job.
tests-swoole.php Starts a local Swoole HTTP server, sends the crafted multipart request, and fails if the target file is deleted.
versions/8.3.env Bumps the Swoole source version to v6.2.5.
versions/8.4.env Bumps the Swoole source version to v6.2.5.
versions/8.5.env Bumps the Swoole source version to v6.2.5.

Reviewed 6e785a8 · Details · Comment @appwrite review to re-run, or mention @appwrite with a question.

@appwrite appwrite Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@loks0n
loks0n merged commit 355ad40 into main Nov 9, 2026
20 checks passed
@loks0n
loks0n deleted the chore/swoole-6.2.5 branch November 9, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant