Repository navigation
fix: clone ffmpeg from GitHub instead of fetching ffmpeg.org - #6
Merged
Merged
Conversation
ffmpeg.org resets or times out connections from GitHub Actions runners, and curl retries do not outlast it. Clone the release tag from the GitHub mirror with a shallow checkout, the same way the swoole stage already builds its pinned source. The Renovate rule already tracks FFmpeg/FFmpeg tags with the n prefix, so the pin keeps updating. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
ffmpegbuild stage now clones the release tag from the GitHub mirror with a shallow checkout instead of downloading the source tarball from ffmpeg.org. This matches how theswoolestage in this Dockerfile, and the other utopia-php Dockerfiles, already fetch their pinned sources.Why
ffmpeg.org resets or times out connections from GitHub Actions runners. In appwrite/appwrite it failed four image builds in a row today (
Recv failure: Connection reset by peer, and oneFailed to connect ... after 133568 ms), and curl retries do not outlast an outage of that length. GitHub is reliable from runners. The same change landed in the Appwrite Dockerfile in appwrite/appwrite#15236.Notes
gitreplacescurlandxzin the stage's apk list.FFmpeg/FFmpegtags with thenprefix, soFFMPEG_VERSIONkeeps updating and the clone usesn${FFMPEG_VERSION}directly.VERSIONfile, soffmpeg -versionreports the tag name (n8.1.2) rather than8.1.2. Nothing in the library parses that string;Process::exists()only checks the binary runs.🤖 Generated with Claude Code