Repository navigation
docs: stop recommending wildcard routes as error pages - #6617
Merged
Merged
Conversation
A React wildcard view, `views/{...wildcard}.tsx` or a view with
`route: '*'` in its ViewConfig, takes the place of the Flow fallback for
every path under its directory. Flow views under that directory then
show the wildcard view instead, so a wildcard directly in `views` hides
every Flow view of a hybrid application.
The Wildcard Parameters section of the React navigation guide now uses
a document browser as its example and warns about Flow views, as on
main. The Hilla routing guide no longer shows a `route: '*'` error page
and points to a custom Flow not-found view instead.
Escape the ellipsis in the wildcard file names, which Asciidoctor
rendered as an ellipsis character outside source blocks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
This pull request targets If the change applies only to this release, remove the label. |
Contributor
Preview DeploymentThis PR has been deployed for preview. URL: https://docs-preview-pr-6617.fly.dev Changed pagesAdded content is highlighted in green; removed content is marked in red on each page.
Base branch changesNot marked in the preview: v25.3 is a maintenance branch, not a stacked pull request branch. Everything highlighted in the preview belongs to this PR. Built from 7898a64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pages on
v25.3advise using a React wildcard view as a "page not found" page. In an application with Flow views, this hides the Flow views: a wildcard view (views/{...wildcard}.tsx, or a view withroute: '*'in itsViewConfig) takes the place of the Flow fallback for every path under its directory. The Flow views under that directory then show the wildcard view instead, for a direct page load, a<NavLink>andnavigate(), with or without a root@layout.tsx. A custom Flow not-found view works as the replacement.Changes:
main. The example is now a document browser atviews/docs/{...path}.tsx, followed by a paragraph that warns about the Flow views and links to Custom Exception Handlers.route: '*'example with a pointer to a custom Flow not-found view, and a warning about wildcard routes in applications with Flow views. The heading and its anchor are unchanged; nothing else links to it.{pass:[...]name}). Asciidoctor rendered it as an ellipsis character in inline code and in the block title, as the published page shows today. The block title is now monospace, which also keeps Vale's ellipsis rule from flagging it.The behavior was confirmed in a running 25.4.0-alpha5 application while working on #6616.
maingets this fix through #6616, so this pull request is not for cherry-picking tomain.Checks: Vale reports nothing on the changed lines, the redirect check passes against
v25.3, and the new link's anchor exists on the published page.🤖 Generated with Claude Code