Repository navigation
ci: update the code review action to keep security weaknesses out of findings - #6629
Merged
Merged
Conversation
…findings Pins vaadin/github-actions/code-review to ae1f782. The code review now has a security area, and neither profile reports or hints at a pre-existing security weakness, since findings are public.
vaadin-review-bot
left a comment
vaadin-review-bot
left a comment
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
Contributor
|
Hi @totally-not-ai[bot] and @peholmst, when i performed cherry-pick to this commit to v25.3, i have encountered the following issue. Can you take a look and pick it manually? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review risk: two-way door — only the PR code-review workflow; revert the one-line pin to go back.
Summary
Updates the pinned
vaadin/github-actions/code-reviewaction from5e91962to the currentmain(ae1f782). This picks up vaadin/github-actions#34 (asecurityarea in the code review prompt) and vaadin/github-actions#35 (neither the code nor the docs review reports or hints at a pre-existing security weakness, since findings are public).What changed
.github/workflows/code-review.yml: action pin5e91962→ae1f782. No inputs changed.Test summary
actionlinton the workflow (no new findings).Working on behalf of Artur