Repository navigation
[WRONG BRANCH] fix(oauth): xAI login waits 20 minutes for the pasted address (AgentRadar 20115) - #12
Draft
vadymhimself wants to merge 1 commit into
Draft
vadymhimself wants to merge 1 commit into
vadymhimself wants to merge 1 commit into
Conversation
…adar 20115) A hosted Grok sign-in pastes the final address back by hand. The flow kept the callback server's 300 s default, so a paste 5-6 minutes after the start failed with no reason. It now waits 20 minutes, the window AgentRadar offers. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
changed the title
⏳ DRAFT
What to do
Its title has been prefixed with |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A hosted Grok sign-in pastes the final address back by hand.
XaiOAuthFlowpassed notimeoutMs, so it kept the callback server's 300 s default, and a paste 5-6 minutes after the start failed with no reason (AgentRadar tester, 4 failed flows on 11-08). The flow now waits 20 minutes, the window AgentRadar offers for every pasted sign-in except Claude (whose code flow already sets 10 minutes).src/oauth/xai.ts:XAI_LOGIN_TIMEOUT_MS = 20 * 60_000, passed astimeoutMs.tests/oauth/xai-login-window.test.ts: the flow'stimeoutMsis 20 minutes.Local run: the new test passes (bun 1 pass 0 fail); the AgentRadar lane could not witness this checkout (git ENOBUFS), so CI here is the recorded run.
tests/oauth/oauth-callback-server.test.ts'a non-callback request cannot pin the socket to the retiring flow' fails on the base commit too, unchanged by this PR.Draft on purpose: it ships only in a fork release after .16 (held by Vadym on AgentRadar lidge-jun#5330), together with an AgentRadar change that sets Grok's paste window back to 20 minutes.
Eval added/updated: N/A deterministic (unit test: tests/oauth/xai-login-window.test.ts)
🤖 Generated with Claude Code