Fix (Waypoints): clear placeholder results on panel close (#365)#399
Open
AaravJalan wants to merge 6 commits intovalhalla:masterfrom
Open
Fix (Waypoints): clear placeholder results on panel close (#365)#399AaravJalan wants to merge 6 commits intovalhalla:masterfrom
AaravJalan wants to merge 6 commits intovalhalla:masterfrom
Conversation
- Skip reverse geocode when use_geocoding is disabled - Remove 500ms loading delay
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/399 |
Author
|
GSOC Contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes Issue
Closes #365
When the directions panel was closed and reopened, waypoints that were in a loading/placeholder state (coordinate pinned on map, reverse geocode still in flight, or just completed) would re-render with stale data — making it appear as if a waypoint had been populated when the user hadn't finished setting one.
👨💻 Changes proposed
src/stores/directions-store.tsclearPlaceholderWaypointsaction toDirectionsActionsinterfacetitle), resetting bothgeocodeResultsanduserInputto emptysrc/components/route-planner.tsxclearPlaceholderWaypoints()beforetoggleDirections()on sheet close, so placeholder state is always cleaned up when the panel is dismissedsrc/components/directions/waypoints/waypoint-item.tsxidinstead ofindexto prevent stale index references from causing wrong data to render after array mutationsType of Change