Disable the creation of default ArgoCD instance by the Gitops Operator#525
Conversation
|
Hi @sector2000. Thanks for your PR. I'm waiting for a validatedpatterns member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We want to avoid that the ArgoCD instance is initially deployed with default settings and then redeployed with our customizations. The DISABLE_DEFAULT_ARGOCD_INSTANCE flag in the Gitops Subscription prevents the default instance from being created by the Gitops Operator. The reason for this choice is that the first default deployment might not be configured properly (for example missing Git server certificates) and the Applications will be in failed state until ArgoCD is redeployed by the Patterns Operator
sector2000
force-pushed
the
disable-default-argocd-instance
branch
from
068059f to
1064d72
Compare
|
/ok-to-test |
|
I'll merge this, but I need to also add a watch on the argocd object we create otherwise on upgrades, the clusterwide argo on the hub will just disappear until the pattern-operator pod gets restarted |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaldessari, sector2000 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mbaldessari why do you think the main ArgoCD instance would disappear during upgrade of the patterns operator? Is the operator anytime deleting it? |
openshift-merge-bot
bot
merged commit 3f71e70
into
validatedpatterns:main
|
Yeah, the gitops operator will remove it (I tested the upgrade path and noticed that) #526 should fix that |
|
Interesting. Thanks for the fix! |
2 participants
The
Gitops Operator, right after being installed, creates a defaultArgoCDinstance with nameopenshift-gitopsin theopenshift-gitopsnamespace.This instance might not be configured properly (for example missing git server certificates), so the Applications might be in error state.
The
Patterns Operatorwill then modify theopenshift-gitopsArgoCDobject with the correct settings and the instance will be redeployed.Instead, we can just tell the
Gitops Operatornot to create the defaultopenshift-gitopsinstance, setting the environment variableDISABLE_DEFAULT_ARGOCD_INSTANCE=truein theGitops OperatorSubscription.The instance will be then created directly by the
Patterns Operator, with the correct settings.