Tickets - credit first responder on owner self-close#274
Merged
Conversation
When a ticket owner closed their own ticket, record_ticket_closed skipped the staff stats block entirely, so the assigned/first-responding staff member never received tickets_closed credit, resolution time, or a TICKET_CLOSED event. The function already attributes ticket.claimed_by to the first responder when no explicit claimer exists, so route close credit to that staff member on self-close. https://claude.ai/code/session_01PcnLXE9Ek2Yu6tChjDp3Vc
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes ticket analytics attribution so that when a ticket owner self-closes their own ticket, the relevant staff member (claimer or first responder) still receives “tickets closed” credit, resolution-time aggregation, and a TICKET_CLOSED staff event.
Changes:
- Updates
record_ticket_closedto compute astaff_credit_idfor closures. - Credits the closing staff member when applicable, otherwise credits the attributed staff member (
ticket.claimed_by) on owner self-close.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a ticket owner closed their own ticket, record_ticket_closed
skipped the staff stats block entirely, so the assigned/first-responding
staff member never received tickets_closed credit, resolution time, or
a TICKET_CLOSED event. The function already attributes ticket.claimed_by
to the first responder when no explicit claimer exists, so route close
credit to that staff member on self-close.
https://claude.ai/code/session_01PcnLXE9Ek2Yu6tChjDp3Vc