Repository navigation
fix(sbom): keep SemVer build metadata in scan and SBOM JSON - #427
Open
vibgrate-team wants to merge 2 commits into
Open
vibgrate-team wants to merge 2 commits into
vibgrate-team wants to merge 2 commits into
Conversation
semver.clean and semver.valid drop the +build suffix before a version is recorded. Scan JSON and vg sbom now keep the canonical token (1.2.3+build.4, and Go 2.0.0+incompatible). Package URLs still percent-encode + as %2B. A version that cannot be percent-encoded keeps the component and omits the purl with an actionable warning. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Versions with SemVer build metadata (for example
1.2.3+build.4) were losing the+…suffix before they reached machine-readable output.semver.cleanandsemver.validreturn onlymajor.minor.patch[-pre], and several scanners stored that stripped string asresolvedVersion.resolvedVersionand SBOM componentversion/versionInfonow keep the canonical token from the lockfile or manifest, including Go2.0.0+incompatible(the leadingvis still removed). Range checks still ignore build metadata.+: the version field stays1.2.3+build.4, and the purl version is percent-encoded (pkg:npm/name@1.2.3%2Bbuild.4).Related issues
Closes #298
Checklist
pnpm testpassespnpm lintis cleanpnpm typecheckis cleangraph.json/ report output (content-hashed IDs, stable sorts; no time,randomness, or filesystem-order dependence)
git commit -s, DCO)Notes for reviewers
pnpm test(5174 passed),pnpm lint, andpnpm typecheckwere run on this branch. Lint reports five pre-existing unused-variable warnings outside this change.Go advisory ranges are unchanged: comparison still reduces
2.0.0+incompatibleto2.0.0. An explicitversionslist now matches the recorded string, so2.0.0does not match that finding and2.0.0+incompatibledoes.v2.0.0+incompatiblestill does not.