fix: Safari playback stall with overrideNative and experimentalUseMMS#1601
fix: Safari playback stall with overrideNative and experimentalUseMMS#1601Demenus wants to merge 1 commit intovideojs:mainfrom
Conversation
src/playlist-controller.js
Outdated
| options.overrideNative && | ||
| options.experimentalUseMMS && |
There was a problem hiding this comment.
| options.overrideNative && | |
| options.experimentalUseMMS && |
I think these can be removed. If this code is reached, it's not native playback. And without the MMS check this seems to fix videojs/video.js#9117 too.
There was a problem hiding this comment.
You are right — at that point in the code we are no longer using native playback.
I have removed those flags from the condition.
Thank you for the fast review 👍🏻
Safari playback does not start when using overrideNative together with experimentalUseMMS. This appears to be caused by setting the segment metadata track mode to 'hidden', which can stall playback in Safari when using Managed Media Source. Disable the metadata track in this specific scenario to prevent Safari from processing it and allow playback to start normally. Fixes videojs#1600
c1d2960 to
84a44ef
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
=======================================
Coverage 84.00% 84.01%
=======================================
Files 44 44
Lines 11713 11716 +3
Branches 2625 2627 +2
=======================================
+ Hits 9840 9843 +3
Misses 1873 1873 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is there any way for me to help push this forward? Would love to see this issue fixed. |
|
I can no longer reproduce the issue in #1600 with the example there. I've updated to Mac OS/Safari 26.4 so perhaps there's been a change in Safari. @Demenus do you experience the same? Unfortunately it was a false positive that this would also resolve videojs/video.js#9117. It was only appearing to do so as the version of video.js in this repo's package-lock.json is a bit outdated. |
Description
Safari playback does not start when using overrideNative together with experimentalUseMMS.
This appears to be caused by setting the segment metadata track mode to hidden, which can stall playback in Safari when using Managed Media Source.
Disabling the metadata track in this specific scenario prevents Safari from processing it and allows playback to start normally.
Fixes #1600
This behavior seems specific to Safari when using MMS. Other browsers (Chrome, Firefox) do not appear to be affected by this issue.
Specific Changes proposed
overrideNative+experimentalUseMMSsegmentMetadataTrack_.mode = 'disabled'instead ofhiddenin this specific scenariohidden) for all other browsers and configurationsRequirements Checklist