Delete gear instead of un-equipping gear when using the Premade Gear NPC on GM Island#3279
Open
IamTirion wants to merge 2 commits intovmangos:developmentfrom
Open
Delete gear instead of un-equipping gear when using the Premade Gear NPC on GM Island#3279IamTirion wants to merge 2 commits intovmangos:developmentfrom
IamTirion wants to merge 2 commits intovmangos:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This pull request changes it so that when you choose a set of gear from the Premade Gear NPC on GM Island, your current gear is deleted instead of unequipped.
The problem with un-equipping gear is that it quickly fills your bags up.
And let's say, you switched from gear set 1 to gear set 2, and then you want to switch back to gear set 1, all using the Premade Gear NPC. It doesn't re-equip the gear you have in your bags. It just creates gear set 1 again. So you are left with many duplicated gear.
This also fixes the bug when you select an option from the Premade Gear NPC, and some gear is missing. The bug is caused by the server failing to create a Unique item that you already have. This PR fixes it by deleting the Unique item on you first, before creating a new one.
How2Test