Improve bot pet handling.

[mserajnik]

🍰 Pullrequest

This improves bot pet handling via a few separate commits:

1. 3586ea8: This enables autocasting for bot pet spells (fixes 🐛 [Bug]Battlebot pets don't have spells or won't use them #2474).
2. 8d866e4: This gets rid of the hardcoded list of 17 pets and instead lets Hunter bots select from a much larger pool, to add some variety.
3. d7e63d7: This adds a fallback for Warlock pets that allows Warlock bots without a matching premade spec (so below level 19) to still summon pets, which makes them more useful in lower level content. The fallback only applies if there is no premade spec or if a premade spec doesn't provide any summon spells (which felt like the better way to do it for completeness' sake, instead of just hardcoding it below level 19).
4. a3fc22b: This just wraps the GetPrimaryItemStatForClassAndRole() function into an anonymous namespace, so the helper is not globally exported as a free function.

As an addition for 3.), I also have a commit prepared that teaches Warlock bots all Grimoire pet spells they can learn at their level automatically, but I left this out of this PR for now because I don't want to bloat it too much and I am also not sure if this is something we even want to add. If there are no objections, I will make a follow-up PR for that later.

Proof

• None

Issues

• Fixes 🐛 [Bug]Battlebot pets don't have spells or won't use them #2474

How2Test

Hunter bots

1. Create a character using a GM account
2. .levelup 9
3. .partybot add hunter
4. Observe the Hunter partybot summons a pet from the now broader pool
5. Target a mob
6. .partybot attackstart
7. Observe that the Hunter pet uses spells

Warlock bots

1. Create a character using a GM account
2. .levelup 9
3. .partybot add warlock
4. Observe the Warlock partybot summons an Imp or a Voidwalker
5. Target a mob
6. .partybot attackstart
7. Observe that the Imp starts using Firebolt or that the Voidwalker starts using Torment

Todo / Checklist

• None