Skip to content

fix(migration): rewrite named catalogs#1493

Merged
fengmk2 merged 13 commits intovoidzero-dev:mainfrom
lyzno1:codex/migration-named-catalogs
May 6, 2026
Merged

fix(migration): rewrite named catalogs#1493
fengmk2 merged 13 commits intovoidzero-dev:mainfrom
lyzno1:codex/migration-named-catalogs

Conversation

@lyzno1
Copy link
Copy Markdown
Contributor

@lyzno1 lyzno1 commented Apr 28, 2026

Summary

  • rewrite default and named workspace catalogs for Vite/Vitest replacements across pnpm, Yarn, and Bun
  • preserve catalog:<name> specs and existing peer dependency ranges during package rewrites
  • avoid unsupported Yarn optionalDependencies catalog specs; use concrete override specs there
  • keep file: override mode out of catalogs and peer dependency specs

Tests

  • pnpm tool sync-remote
  • vp i --frozen-lockfile --ignore-scripts
  • just build
  • pnpm bootstrap-cli
  • vp test run packages/cli/src/migration/__tests__/migrator.spec.ts packages/cli/src/migration/__tests__/bun-catalog-file-protocol.spec.ts
  • pnpm -C packages/cli snap-test-local
  • pnpm -C packages/cli snap-test-global
  • pnpm tsgo

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 28, 2026

Deploy Preview for viteplus-preview ready!

Name Link
🔨 Latest commit ae92358
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69fad338a9a57c0008f06965
😎 Deploy Preview https://deploy-preview-1493--viteplus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@lyzno1 lyzno1 force-pushed the codex/migration-named-catalogs branch from ce7f556 to fb8a9a1 Compare April 28, 2026 03:50
@lyzno1 lyzno1 marked this pull request as draft April 28, 2026 03:51
@lyzno1 lyzno1 force-pushed the codex/migration-named-catalogs branch from fb8a9a1 to 287327e Compare April 28, 2026 04:11
@lyzno1 lyzno1 marked this pull request as ready for review April 28, 2026 07:07
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0cef4510a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/migration/migrator.ts
@lyzno1 lyzno1 marked this pull request as draft April 28, 2026 07:23
@lyzno1
Copy link
Copy Markdown
Contributor Author

lyzno1 commented Apr 28, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lyzno1 lyzno1 marked this pull request as ready for review April 28, 2026 09:39
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f8c561db5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/migration/migrator.ts Outdated
@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented May 6, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyzno1 Thanks! Nice job!

@fengmk2 fengmk2 added test: e2e Auto run e2e tests test: create-e2e Run `vp create` e2e tests labels May 6, 2026
@fengmk2 fengmk2 merged commit 730dc41 into voidzero-dev:main May 6, 2026
136 of 156 checks passed
@lyzno1 lyzno1 deleted the codex/migration-named-catalogs branch May 6, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants