Skip to content

fix: Fish env setup using string literal command when using vp env commands #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikkurogue wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −3
Open

fix: Fish env setup using string literal command when using vp env commands #1518

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d72e608
Fix the fish setup to not run `command` but the actual parsed argv to…
mikkurogue May 5, 2026
13a04db
Apply change to test to assert correctly for fish reflecting current …
mikkurogue May 6, 2026
4c21c9b
Merge branch 'main' into fish-setup
mikkurogue May 6, 2026
75a2946
revert some __VP_BIN__/ changes to use command again instead only on …
mikkurogue May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/vite_global_cli/src/commands/env/setup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ function vp
command vp $argv; return
end
set -lx VP_ENV_USE_EVAL_ENABLE 1
set -l __vp_out (env FISH_VERSION=$FISH_VERSION command vp $argv); or return $status
set -l __vp_out (env FISH_VERSION=$FISH_VERSION __VP_BIN__/vp $argv); or return $status
eval (string join ';' $__vp_out)
else
command vp $argv
Expand Down Expand Up @@ -1015,8 +1015,8 @@ mod tests {
"env.fish should check for 'use' subcommand"
);
assert!(
fish_content.contains("command vp $argv"),
"env.fish should use 'command vp' for passthrough"
fish_content.contains("/vp $argv"),
"env.fish should use absolute path to vp for passthrough"
);
}

Expand Down