Skip to content

test(e2e): skip rollipop typeerror check#383

Merged
fengmk2 merged 1 commit intomainfrom
01-04-test_e2e_skip_rollipop_lint_check
Jan 4, 2026
Merged

test(e2e): skip rollipop typeerror check#383
fengmk2 merged 1 commit intomainfrom
01-04-test_e2e_skip_rollipop_lint_check

Conversation

@fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jan 4, 2026

TL;DR

Enable E2E tests to run on PRs that modify the CI workflow and optimize test commands.

What changed?

  • Added a pull_request trigger for the E2E test workflow when changes are made to ecosystem-ci/** or the workflow file itself
  • Optimized the Playwright installation for vibe-dashboard to only install Chromium instead of all browsers
  • Made the lint command for the rollipop project non-blocking by adding || true due to a TypeScript ESLint issue

How to test?

  1. Make changes to files in the ecosystem-ci/ directory or the .github/workflows/e2e-test.yml file
  2. Verify that the E2E test workflow runs automatically on your PR
  3. Check that the vibe-dashboard test uses only Chromium
  4. Confirm that the rollipop build continues even if the lint step fails

Why make this change?

  • Running E2E tests on relevant PRs helps catch issues before they're merged to main
  • Installing only Chromium for Playwright tests reduces CI time and resource usage
  • Making the lint command non-blocking prevents CI failures due to a known TypeScript ESLint issue while still providing lint feedback

Copy link
Member Author

fengmk2 commented Jan 4, 2026

@fengmk2 fengmk2 self-assigned this Jan 4, 2026
@fengmk2 fengmk2 force-pushed the 01-04-test_e2e_skip_rollipop_lint_check branch from 43f3c68 to 402e5df Compare January 4, 2026 09:34
@fengmk2 fengmk2 changed the title test(e2e): skip rollipop lint check test(e2e): skip rollipop typeerror check Jan 4, 2026
@fengmk2 fengmk2 marked this pull request as ready for review January 4, 2026 09:34
@fengmk2 fengmk2 requested review from Brooooooklyn and Copilot and removed request for Copilot January 4, 2026 09:34
@fengmk2 fengmk2 requested a review from branchseer January 4, 2026 10:03
@fengmk2 fengmk2 merged commit 0971535 into main Jan 4, 2026
23 checks passed
@cloudflare-workers-and-pages
Copy link

Deploying vite-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 402e5df
Status:⚡️  Build in progress...

View logs

Copy link
Member Author

fengmk2 commented Jan 4, 2026

Merge activity

@fengmk2 fengmk2 deleted the 01-04-test_e2e_skip_rollipop_lint_check branch January 4, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants